Re: [Qemu-devel] [PATCH/RFC 0/7] Screendump to UNIX socket & in PNG format

[Michael Roth]

On Mon, Mar 12, 2012 at 01:57:14PM -0500, Anthony Liguori wrote:
> On 03/12/2012 01:56 PM, Marc-André Lureau wrote:
> >On Mon, Mar 12, 2012 at 7:53 PM, Anthony Liguori<address@hidden>  wrote:
> >>Why not just return the screendump through QMP?
> >
> >in base64, base85?
> 
> I think Jan had patches for base64 blobs but I think it got tangled
> up in VMState related controversy.

Few months back, was planning on using them for qemu-ga. Looks like
they're not in yet, but FWIW qemu-ga has been using g_base64_encode() since
initial commit. I think Jan had some reservations about g_base64_decode()'s
error-handling, but that shouldn't be an issue in this particular case.

I agree on the QMP approach sounding a whole lot cleaner, especially
given that Juan recently did a some cleanups to remove non-migration
QEMUFile users:

3a230256e8418f5cc9761f36feb6952d7ca38d73

> 
> Jan, am I correct?
> 
> Regards,
> 
> Anthony Liguori
> 
>