Re: [Qemu-devel] [PATCH RFC v4 44/44] qom: Introduce CPU class

[Paolo Bonzini]

Il 13/03/2012 13:13, Andreas Färber ha scritto:
> > It will be easier to generalize later qdev code and not make special
> > case when adding cpus.
> 
> I never heard anyone wanting to generalize reset so far. I don't think
> it belongs into Object at least. Maybe DeviceState. Anthony? Paolo?

I believe long term we want CPUs to become a DeviceState.  For now, I
think Andreas's prototype is fine.  Methods should not take a superclass
argument in general.

> This series is taking much too long to move forward (the QOM "steam"
> seems to be gone?) and I'm worried that introducing much more basic 
> infrastructure will make review and applying even slower, cf. 
> object_class_foreach_ordered()/_get_list().

Agreed, this series looks more or less good (and mostly mechanical
anyway).  Is it an RFC or what? :)  I wonder if reviewers are put off by
the subject.

Paolo