[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/2] qxl trace events
From: |
Alon Levy |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/2] qxl trace events |
Date: |
Wed, 14 Mar 2012 12:59:39 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Mar 14, 2012 at 10:20:13AM +0000, Stefan Hajnoczi wrote:
> On Tue, Mar 13, 2012 at 08:06:39PM +0200, Alon Levy wrote:
> > This is split from the previous screendump change patchset, hence the v2.
> >
> > This is by no way complete but I think it is a good start, and frankly I'd
> > like
> > to stop here right now.
> >
> > Changes from v1:
> > add qid prefix to all tracepoints (except vga update which makes no sense)
> > rename to ring where suggested (Gerd)
> > add some trace points to spice-display
> > drop enter/exit in favor of a single command (Gerd)
> > some sorting of the trace event list
> >
> > Alon Levy (2):
> > qxl: switch qxl.c to trace-events
> > qxl/qxl_render.c: add trace events
> >
> > hw/qxl-render.c | 13 ++---
> > hw/qxl.c | 156
> > +++++++++++++++++++++++++---------------------------
> > trace-events | 66 ++++++++++++++++++++++
> > ui/spice-display.c | 13 ++++-
> > 4 files changed, 157 insertions(+), 91 deletions(-)
>
> Some of the trace events have >6 arguments, which is the limit for the
> 'simple' trace backend today. The limit may be lifted in the near
> future but it would still be nice to avoid using >6 arguments today.
OK, I'll split up events then.
>
> Stefan
>