[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] coroutine-gthread.c: Avoid threading APIs depre
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] coroutine-gthread.c: Avoid threading APIs deprecated in GLib 2.31 |
Date: |
Thu, 15 Mar 2012 11:21:48 +0000 |
On Sat, Mar 3, 2012 at 2:52 PM, Peter Maydell <address@hidden> wrote:
> The GLib threading APIs were revamped in GLib 2.31 and a number
> of the old interfaces were deprecated, which means they provoke
> compilation warnings (errors if -Werror) now. Add support for the
> new interfaces while retaining the old ones so we can still compile
> on older versions of GLib too.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> In particular, this fixes compilation failure on ARM hosts running
> Ubuntu Precise. Seems kinda ugly to me, suggestions for improvement
> welcomed.
It's ugly but it won't cause larger scale problems, so we should
probably pick this up.
I was wondering if this is a legitimate case to override warnings -
because the new library probably still supports the deprecated
functions. But eventually we need to bite the bullet and convert the
code.
Stefan