[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/8] ds1338: Add missing break statement
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 3/8] ds1338: Add missing break statement |
Date: |
Mon, 19 Mar 2012 12:22:55 +0000 |
From: Stefan Weil <address@hidden>
Without the break statement, case 5 sets month and year from the same
data. This does not look correct.
The missing break was reported by splint.
Signed-off-by: Stefan Weil <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Reviewed-by: Andreas Färber <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
hw/ds1338.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/ds1338.c b/hw/ds1338.c
index 6397f0a..d590d9c 100644
--- a/hw/ds1338.c
+++ b/hw/ds1338.c
@@ -100,6 +100,7 @@ static int ds1338_send(I2CSlave *i2c, uint8_t data)
break;
case 5:
s->now.tm_mon = from_bcd(data & 0x1f) - 1;
+ break;
case 6:
s->now.tm_year = from_bcd(data) + 100;
break;
--
1.7.9.1
- [Qemu-devel] [PULL 0/8] Trivial patches for 8 to 19 March 2012, Stefan Hajnoczi, 2012/03/19
- [Qemu-devel] [PATCH 3/8] ds1338: Add missing break statement,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 8/8] qemu-ga: for w32, fix leaked handle ov.hEvent in ga_channel_write(), Stefan Hajnoczi, 2012/03/19
- [Qemu-devel] [PATCH 7/8] ioapic: fix build with DEBUG_IOAPIC, Stefan Hajnoczi, 2012/03/19
- [Qemu-devel] [PATCH 2/8] vnc: Fix packed boolean struct members, Stefan Hajnoczi, 2012/03/19
- [Qemu-devel] [PATCH 5/8] cleanup obsolete typedef, Stefan Hajnoczi, 2012/03/19
- [Qemu-devel] [PATCH 6/8] .gitignore: add qemu-bridge-helper and option rom build products, Stefan Hajnoczi, 2012/03/19
- [Qemu-devel] [PATCH 4/8] monitor: Remove unused bool field 'qapi' in mon_cmd_t struct, Stefan Hajnoczi, 2012/03/19
- [Qemu-devel] [PATCH 1/8] Remove type field in ModuleEntry as it's not used, Stefan Hajnoczi, 2012/03/19
- Re: [Qemu-devel] [PULL 0/8] Trivial patches for 8 to 19 March 2012, Anthony Liguori, 2012/03/19