[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool |
Date: |
Mon, 19 Mar 2012 12:32:19 +0000 |
On Mon, Mar 19, 2012 at 12:05 PM, Lee Essen <address@hidden> wrote:
> On 19 Mar 2012, at 11:59, Stefan Hajnoczi wrote:
>
>> On Fri, Mar 16, 2012 at 12:29 PM, Lee Essen <address@hidden> wrote:
>>> Signed-off-by: Lee Essen <address@hidden>
>>>
>>> ---
>>>
>>> scripts/tracetool | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> I'm going to spend some time today reviewing recent tracing patches.
>> I'd prefer to move to a Python version of tracetool rather than worry
>> about the shell quirks across all host platforms.
>>
>> If the Python rewrite cannot be merged for 1.1 then it makes sense to
>> go with shell portability fix.
>
> Hi Stefan,
>
> While you are looking at this, there are a couple of other related issues
> worth having in the back of your mind:
>
> 1. "self" is a reserved word in Solaris/Illumos trace, and it's used in a few
> trace calls.
> 2. "bool" isn't recognised by default, again used in a couple of traces ...
> could be fixed by typedef, but switching to int is probably better (imho)
> 3. Some work is needed on the linking stage when using Solaris/Illumos
> dtrace. You need to provide all the objs to the dtrace -G call in order to
> get an object generated that includes all of the relevant symbols in it.
> Happy to provide more detail if needed.
If you already have patches for these points then please send them.
You, I, or someone else can port them to Python.
Stefan
- [Qemu-devel] [PATCH] fix incorrect bracket in tracetool, Lee Essen, 2012/03/16
- Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool, Paolo Bonzini, 2012/03/16
- Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool, Stefan Hajnoczi, 2012/03/19
- Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool, Lee Essen, 2012/03/19
- Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool,
Stefan Hajnoczi <=
- Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool, Andreas Färber, 2012/03/19
- Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool, Lee Essen, 2012/03/19
- Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool, Stefan Hajnoczi, 2012/03/20
- Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool, Lee Essen, 2012/03/20
- Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool, Stefan Hajnoczi, 2012/03/21
- Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool, Stefan Weil, 2012/03/19
- Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool, Andreas Färber, 2012/03/19