[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv4 04/11] consolidate qemu_iovec_memset{, _skip}(
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCHv4 04/11] consolidate qemu_iovec_memset{, _skip}() into single function and use existing iov_memset() |
Date: |
Mon, 19 Mar 2012 14:36:13 +0000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Mar 16, 2012 at 11:19:03AM -0500, Anthony Liguori wrote:
> On 03/15/2012 04:00 PM, Michael Tokarev wrote:
> >This patch combines two functions into one, and replaces
> >the implementation with already existing iov_memset() from
> >iov.c.
> >
> >The new prototype of qemu_iovec_memset():
> > size_t qemu_iovec_memset(qiov, size_t offset, int fillc, size_t bytes)
> >It is different from former qemu_iovec_memset_skip(), and
> >I want to make other functions to be consistent with it
> >too: first how much to skip, second what, and 3rd how many
> >of it. It also returns actual number of bytes filled in,
> >which may be less than the requested `bytes' if qiov is
> >smaller than offset+bytes, in the same way iov_memset()
> >does.
> >
> >While at it, use utility function iov_memset() from
> >iov.h in posix-aio-compat.c, where qiov was used.
> >
> >Signed-off-by: Michael Tokarev<address@hidden>
>
> Please CC Kevin at least when making block changes.
>
> It looks fine to me but would appreciate Kevin/Stefan taking a look too.
I am behind and feel that refactorings like this require careful
technical review but don't buy us much. The best way to get refactoring
in is by making it part of a larger series that fixes a bug or adds a
feature. I don't have bandwidth for non-trivial cosmetic stuff at the
moment, sorry.
Stefan
- [Qemu-devel] [PATCHv4 00/11] cleanup/consolidate iovec functions, Michael Tokarev, 2012/03/15
- [Qemu-devel] [PATCHv4 09/11] export iov_send_recv() and use it in iov_send() and iov_recv(), Michael Tokarev, 2012/03/15
- [Qemu-devel] [PATCHv4 08/11] rename qemu_sendv to iov_send, change proto and move declarations to iov.h, Michael Tokarev, 2012/03/15
- [Qemu-devel] [PATCHv4 01/11] virtio-serial-bus: use correct lengths in control_out() message, Michael Tokarev, 2012/03/15
- [Qemu-devel] [PATCHv4 04/11] consolidate qemu_iovec_memset{, _skip}() into single function and use existing iov_memset(), Michael Tokarev, 2012/03/15
- Re: [Qemu-devel] [PATCHv4 04/11] consolidate qemu_iovec_memset{, _skip}() into single function and use existing iov_memset(), Anthony Liguori, 2012/03/16
- Re: [Qemu-devel] [PATCHv4 04/11] consolidate qemu_iovec_memset{, _skip}() into single function and use existing iov_memset(),
Stefan Hajnoczi <=
- Re: [Qemu-devel] [PATCHv4 04/11] consolidate qemu_iovec_memset{, _skip}() into single function and use existing iov_memset(), Michael Tokarev, 2012/03/19
- Re: [Qemu-devel] [PATCHv4 04/11] consolidate qemu_iovec_memset{, _skip}() into single function and use existing iov_memset(), Anthony Liguori, 2012/03/19
- Re: [Qemu-devel] [PATCHv4 04/11] consolidate qemu_iovec_memset{, _skip}() into single function and use existing iov_memset(), Stefan Hajnoczi, 2012/03/20
[Qemu-devel] [PATCHv4 10/11] cleanup qemu_co_sendv(), qemu_co_recvv() and friends, Michael Tokarev, 2012/03/15
[Qemu-devel] [PATCHv4 06/11] consolidate qemu_iovec_copy() and qemu_iovec_concat() and make them consistent, Michael Tokarev, 2012/03/15
[Qemu-devel] [PATCHv4 11/11] rewrite iov_send_recv() and move it to iov.c, Michael Tokarev, 2012/03/15
[Qemu-devel] [PATCHv4 07/11] change qemu_iovec_to_buf() to match other to, from_buf functions, Michael Tokarev, 2012/03/15