qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/3] add --confdir option to configure


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 0/3] add --confdir option to configure
Date: Mon, 19 Mar 2012 10:34:06 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2

On 03/19/2012 10:31 AM, Eduardo Habkost wrote:
On Mon, Mar 19, 2012 at 10:14:54AM -0500, Anthony Liguori wrote:
On 03/19/2012 09:47 AM, Eduardo Habkost wrote:
This series change the Makefile to use $(confdir) instead of
$(sysconfdir)/qemu, and allows the full config path configurable instead of
forcing the use of $(sysconfdir)/qemu.

What's the use case here?  Is this to allow $(sysconfdir)/qemu-kvm?

Yes. On RHEL we usually package qemu-kvm only, but we try to avoid
conflicts in case other flavors of qemu be provided by third-parties
(read: EPEL).


I'd rather we use a PACKAGE_NAME define to do that and have qemu-kvm
change PACKAGE_NAME.

I tried to mimic --mandir, --datadir, --docdir, and all other options
that expect full paths instead of trying to building one itself.

A --package-name option could be provided to make it easier to override
all the defaults at the same time, but I don't see why not include an
option to define the full path for confdir, just like we allow for
datadir, docdir, and mandir.

No, I'm not suggesting --package-name, I'm suggesting that qemu-kvm would carry a patch to configure that changed a fixed PACKAGE_NAME define.

Regards,

Anthony Liguori






reply via email to

[Prev in Thread] Current Thread [Next in Thread]