Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command

[Brad Smith]

On 20/03/12 6:14 AM, Michal Privoznik wrote:
> On 18.03.2012 02:09, Brad Smith wrote:
> > Michal,
> >
> > http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2
> >
> >
> > This broke the build. Un-break the tree.
>
>
> Can you please be more specific? It works for me so I don't have a clue
> what are you referring to. I mean, what compiler do you use, what errors
> are thrown, etc.
>
> Michal

The patch commited is full of Linux specific code.

  CC    qga/commands-posix.o
In file included from qga/commands-posix.c:29:
/usr/include/arpa/inet.h:74: warning: 'struct in_addr' declared inside 
parameter list
/usr/include/arpa/inet.h:74: warning: its scope is only this definition 
or declaration, which is probably not what you want
/usr/include/arpa/inet.h:75: warning: 'struct in_addr' declared inside 
parameter list
qga/commands-posix.c: In function 'bios_supports_mode':
qga/commands-posix.c:587: error: 'environ' undeclared (first use in this 
function)
qga/commands-posix.c:587: error: (Each undeclared identifier is reported 
only once
qga/commands-posix.c:587: error: for each function it appears in.)
qga/commands-posix.c: In function 'guest_suspend':
qga/commands-posix.c:670: error: 'environ' undeclared (first use in this 
function)
qga/commands-posix.c: In function 'qmp_guest_network_get_interfaces':
qga/commands-posix.c:764: error: 'INET_ADDRSTRLEN' undeclared (first use 
in this function)
qga/commands-posix.c:765: error: 'INET6_ADDRSTRLEN' undeclared (first 
use in this function)
qga/commands-posix.c:789: error: 'SIOCGIFHWADDR' undeclared (first use 
in this function)
qga/commands-posix.c:810: error: 'struct ifreq' has no member named 
'ifr_hwaddr'
qga/commands-posix.c:832: error: dereferencing pointer to incomplete type
qga/commands-posix.c:846: error: dereferencing pointer to incomplete type
qga/commands-posix.c:854: error: dereferencing pointer to incomplete type
qga/commands-posix.c:868: error: dereferencing pointer to incomplete type
qga/commands-posix.c:765: warning: unused variable 'addr6'
qga/commands-posix.c:764: warning: unused variable 'addr4'
gmake: *** [qga/commands-posix.o] Error 1

--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.