Re: [Qemu-devel] [PATCH v4 1/7] RTC: Remove the logic to update time format when DM bit changed

[Zhang, Yang Z]

> -----Original Message-----
> From: Stefano Stabellini [mailto:address@hidden
> Sent: Tuesday, March 20, 2012 10:05 PM
> To: Zhang, Yang Z
> Cc: address@hidden; Paolo Bonzini; address@hidden;
> address@hidden
> Subject: Re: [Qemu-devel] [PATCH v4 1/7] RTC: Remove the logic to update time
> format when DM bit changed
> 
> On Mon, 19 Mar 2012, Zhang, Yang Z wrote:
> > Change DM(date mode) and 24/12 control bit don't affect the internal 
> > registers.
> It only indicates what format is using for those registers. So we don't need 
> to
> update time format when it is modified.
> 
> That might be true, but if the user changes format, then issues a read
> RTC_SECONDS, isn't he going to get the old format, unless we call
> rtc_copy_date here?
You are right. The right fixing is updating the cmos before reading rtc not 
after changing the format. In my patch, it will update the cmos before reading, 
so we don't need this logic again. 

best regards
yang