Re: [Qemu-devel] [PATCH 2/4] add MIPS DSP helpers implement

[Stefan Weil]

Am 12.03.2012 09:32, schrieb Jia Liu:
> This patch is the helper implementation of MIPS ASE DSP.
>
> Signed-off-by: Jia Liu<address@hidden>
> ---
>   target-mips/op_helper.c | 3936 +++++++++++++++++++++++++++++++++++++++++++++++
>   1 files changed, 3936 insertions(+), 0 deletions(-)
>
> diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
> index 87e9799..e6ff3c9 100644
> --- a/target-mips/op_helper.c
> +++ b/target-mips/op_helper.c
> @@ -3409,3 +3409,3939 @@ FOP_COND_PS(le,  float32_le(fst0, 
> fst1,&env->active_fpu.fp_status),
>                    float32_le(fsth0, fsth1,&env->active_fpu.fp_status))
>   FOP_COND_PS(ngt, float32_unordered(fst1, fst0,&env->active_fpu.fp_status)    || 
> float32_le(fst0, fst1,&env->active_fpu.fp_status),
>                    float32_unordered(fsth1, fsth0,&env->active_fpu.fp_status)  || 
> float32_le(fsth0, fsth1,&env->active_fpu.fp_status))
> +
> +/* MIPS DSP functions begin */
> +static inline void set_DSPControl_overflow_flag (uint32_t flag, int position)
>    

Please check your patches using scripts/checkpatch.pl.
There should be no space between function name and argument list
for new functions (some old functions still have that space,
but that's accepted).


> +{
> +    env->active_tc.DSPControl |= (target_ulong)flag<<  position;
> +}
> +
>