qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] usb/vmstate: add parent dev path


From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH] usb/vmstate: add parent dev path
Date: Thu, 22 Mar 2012 15:37:39 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.3) Gecko/20120307 Thunderbird/10.0.3

  Hi,

>> +            .driver   = "USB",
>> +            .property = "full-path",
>> +            .value    = "no",
> 
> This touches on our "favorite" bit/bool topic again. While I agree that
> "no" makes sense for a property of that name, the current code still
> expects "on" and "off". In particular, "yes" would not work as expected.

"no" *does* work as expected though, at least it survived my tests,
thats why I didn't notice.

I can s/no/off/ for consistency, no problem.  Merging your yes/no patch
is fine with me too.

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]