Re: [Qemu-devel] [PATCH 02/10] qapi: fail hard on stack imbalance

[Anthony Liguori]

On 03/22/2012 06:51 AM, Paolo Bonzini wrote:
> QmpOutputVisitor will segfault if an imbalanced end function is
> called.  So we can abort in QmpInputVisitor too.
>
> Signed-off-by: Paolo Bonzini<address@hidden>

Reviewed-by: Anthony Liguori <address@hidden>

Regards,

Anthony Liguori

> ---
>   qapi/qmp-input-visitor.c |    5 +----
>   1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/qapi/qmp-input-visitor.c b/qapi/qmp-input-visitor.c
> index e6b6152..b4013cc 100644
> --- a/qapi/qmp-input-visitor.c
> +++ b/qapi/qmp-input-visitor.c
> @@ -77,11 +77,8 @@ static void qmp_input_push(QmpInputVisitor *qiv, const 
> QObject *obj, Error **err
>
>   static void qmp_input_pop(QmpInputVisitor *qiv, Error **errp)
>   {
> +    assert(qiv->nb_stack>  0);
>       qiv->nb_stack--;
> -    if (qiv->nb_stack<  0) {
> -        error_set(errp, QERR_BUFFER_OVERRUN);
> -        return;
> -    }
>   }
>
>   static void qmp_input_start_struct(Visitor *v, void **obj, const char *kind,