Re: [Qemu-devel] [PATCH] qerror: Add QERR_PROPERTY_SET_AFTER_REALIZE

[Paolo Bonzini]

Il 26/03/2012 17:48, Andreas Färber ha scritto:
> Am 26.03.2012 17:30, schrieb Peter Maydell:
>> Add a new QError QERR_PROPERTY_SET_AFTER_REALIZE for attempts
>> to set a QOM or qdev property after the object/device has been
>> realized. This allows a slightly more informative diagnostic
>> than the previous "Insufficient permission" message.
>>
>> Signed-off-by: Peter Maydell <address@hidden>
>> ---
>> We've talked about the rather unhelpful nature of the "Insufficient
>> permission" diagnostic before:
>> http://lists.gnu.org/archive/html/qemu-devel/2012-02/msg02368.html
>> and I finally got round to writing a patch to improve it...
> 
> Not aware of the submission, I suggested to append this to my series,
> since upstream does not yet have "realize" as such.

Yes, good idea.

>> +#define QERR_PROPERTY_SET_AFTER_REALIZE \
>> +    "{ 'class': 'PropertySetAfterRealize', 'data': { 'device': %s, 
>> 'property': %s } }"
> 
> Properties are no longer a device concept. Can we start using a
> different key name here, e.g., 'type'?

Too late I guess, I prefer consistency.

Paolo