[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io |
Date: |
Tue, 27 Mar 2012 08:17:34 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Mar 27, 2012 at 01:42:23PM +1100, David Gibson wrote:
> Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to
> determine the direction of DMA it is emulating. We already have a
> DMADirection enum designed specifically to encode DMA directions.
> This patch uses it for dma_bdrv_io() as well. This involves removing
> the DMADirection definition from the #ifdef it was inside, but since that
> only existed to protect the definition of dma_addr_t from places where
> config.h is not included, there wasn't any reason for it to be there in
> the first place.
>
> Cc: Kevin Wolf <address@hidden>
>
> Signed-off-by: David Gibson <address@hidden>
> ---
> dma-helpers.c | 20 ++++++++++++--------
> dma.h | 12 ++++++------
> hw/ide/core.c | 3 ++-
> hw/ide/macio.c | 3 ++-
> 4 files changed, 22 insertions(+), 16 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>