[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 04/13] qapi: fail hard on stack imbalance
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PATCH 04/13] qapi: fail hard on stack imbalance |
Date: |
Tue, 27 Mar 2012 09:20:42 -0300 |
From: Paolo Bonzini <address@hidden>
QmpOutputVisitor will segfault if an imbalanced end function is
called. So we can abort in QmpInputVisitor too.
Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Anthony Liguori <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>
---
qapi/qmp-input-visitor.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/qapi/qmp-input-visitor.c b/qapi/qmp-input-visitor.c
index e6b6152..b4013cc 100644
--- a/qapi/qmp-input-visitor.c
+++ b/qapi/qmp-input-visitor.c
@@ -77,11 +77,8 @@ static void qmp_input_push(QmpInputVisitor *qiv, const
QObject *obj, Error **err
static void qmp_input_pop(QmpInputVisitor *qiv, Error **errp)
{
+ assert(qiv->nb_stack > 0);
qiv->nb_stack--;
- if (qiv->nb_stack < 0) {
- error_set(errp, QERR_BUFFER_OVERRUN);
- return;
- }
}
static void qmp_input_start_struct(Visitor *v, void **obj, const char *kind,
--
1.7.9.2.384.g4a92a
- [Qemu-devel] [PULL 00/13]: QMP queue, Luiz Capitulino, 2012/03/27
- [Qemu-devel] [PATCH 02/13] qapi: add struct-errors test case to test-qmp-output-visitor, Luiz Capitulino, 2012/03/27
- [Qemu-devel] [PATCH 01/13] qapi: fix double free in qmp_output_visitor_cleanup(), Luiz Capitulino, 2012/03/27
- [Qemu-devel] [PATCH 03/13] qapi: add a test case for type errors, Luiz Capitulino, 2012/03/27
- [Qemu-devel] [PATCH 05/13] qapi: fix memory leak on error, Luiz Capitulino, 2012/03/27
- [Qemu-devel] [PATCH 06/13] qapi: shortcut visits on errors, Luiz Capitulino, 2012/03/27
- [Qemu-devel] [PATCH 08/13] qapi: untangle next_list, Luiz Capitulino, 2012/03/27
- [Qemu-devel] [PATCH 04/13] qapi: fail hard on stack imbalance,
Luiz Capitulino <=
- [Qemu-devel] [PATCH 07/13] qapi: allow freeing partially-allocated objects, Luiz Capitulino, 2012/03/27
- [Qemu-devel] [PATCH 12/13] qmp: parse commands in strict mode, Luiz Capitulino, 2012/03/27
- [Qemu-devel] [PATCH 09/13] qapi: place outermost object on qiv stack, Luiz Capitulino, 2012/03/27
- [Qemu-devel] [PATCH 11/13] qmp: add and use q type specifier, Luiz Capitulino, 2012/03/27
- [Qemu-devel] [PATCH 13/13] qmp: document strict parsing, Luiz Capitulino, 2012/03/27
- [Qemu-devel] [PATCH 10/13] qapi: add strict mode to input visitor, Luiz Capitulino, 2012/03/27
- Re: [Qemu-devel] [PULL 00/13]: QMP queue, Anthony Liguori, 2012/03/30