Re: [Qemu-devel] [PATCH 3/4] Enable qemu-timer dynticks for Solaris

[Jan Kiszka]

On 2012-03-27 17:01, Paolo Bonzini wrote:
> Il 24/03/2012 17:26, Lee Essen ha scritto:
>> Dynticks was limited to linux. This patch adds Solaris support
>> and ensures a CLOCK_HIGHRES clock is used which is the optimal
>> setup for Solaris systems.
> 
> Looks good, but I would prefer if you tested for timer_create in
> configure and use #ifdef CONFIG_RT_TIMER instead.
> 
>> +#if defined(__sun__)
>> +    if (timer_create(CLOCK_HIGHRES, &ev, &host_timer)) {
>> +#else
>>      if (timer_create(CLOCK_REALTIME, &ev, &host_timer)) {
>> +#endif
> 
> This should be #ifdef CLOCK_HIGHRES.

Are we sure about this is and will remain equivalent and correct?

Also, I found some man page that says CLOCK_HIGHRES is non-adjustable
while CLOCK_REALTIME is. That should make a difference in QEMU.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux