[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tracetool.py: always pass --binary, --target-ar
From: |
Lluís Vilanova |
Subject: |
Re: [Qemu-devel] [PATCH] tracetool.py: always pass --binary, --target-arch, --target-type |
Date: |
Tue, 27 Mar 2012 20:01:54 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) |
Alon Levy writes:
> Signed-off-by: Alon Levy <address@hidden>
> ---
> Makefile.objs | 25 ++++++++++++++++++++++---
> 1 file changed, 22 insertions(+), 3 deletions(-)
> diff --git a/Makefile.objs b/Makefile.objs
> index 8e56f48..0e33f4b 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -373,12 +373,25 @@ else
> trace.h: trace.h-timestamp
> endif
> trace.h-timestamp: $(SRC_PATH)/trace-events $(BUILD_DIR)/config-host.mak
> - $(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/tracetool.py
> --format=h --backend=$(TRACE_BACKEND) < $< > $@," GEN trace.h")
> + $(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/tracetool.py \
> + --format=h \
> + --backend=$(TRACE_BACKEND) \
> + --binary=$(bindir)/$(QEMU_PROG) \
> + --target-arch=$(TARGET_ARCH) \
> + --target-type=$(TARGET_TYPE) \
> + --target-type=$(TARGET_TYPE) < $< > $@, \
> + " GEN trace.h")
> @cmp -s $@ trace.h || cp $@ trace.h
> trace.c: trace.c-timestamp
> trace.c-timestamp: $(SRC_PATH)/trace-events $(BUILD_DIR)/config-host.mak
> - $(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/tracetool.py
> --format=c --backend=$(TRACE_BACKEND) < $< > $@," GEN trace.c")
> + $(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/tracetool.py \
> + --format=c \
> + --backend=$(TRACE_BACKEND) \
> + --binary=$(bindir)/$(QEMU_PROG) \
> + --target-arch=$(TARGET_ARCH) \
> + --target-type=$(TARGET_TYPE) < $< > $@, \
> + " GEN trace.c")
> @cmp -s $@ trace.c || cp $@ trace.c
> trace.o: trace.c $(GENERATED_HEADERS)
> @@ -391,7 +404,13 @@ trace-dtrace.h: trace-dtrace.dtrace
> # rule file. So we use '.dtrace' instead
> trace-dtrace.dtrace: trace-dtrace.dtrace-timestamp
> trace-dtrace.dtrace-timestamp: $(SRC_PATH)/trace-events
> $(BUILD_DIR)/config-host.mak
> - $(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/tracetool.py
> --format=d --backend=$(TRACE_BACKEND) < $< > $@," GEN trace-dtrace.dtrace")
> + $(call quiet-command,$(PYTHON) $(SRC_PATH)/scripts/tracetool.py \
> + --format=d \
> + --backend=$(TRACE_BACKEND) \
> + --binary=$(bindir)/$(QEMU_PROG) \
> + --target-arch=$(TARGET_ARCH) \
> + --target-type=$(TARGET_TYPE) < $< > $@, \
> + " GEN trace-dtrace.dtrace")
> @cmp -s $@ trace-dtrace.dtrace || cp $@ trace-dtrace.dtrace
> trace-dtrace.o: trace-dtrace.dtrace $(GENERATED_HEADERS)
> --
> 1.7.9.3
I don't see the reason for such a change, as in the current bash code it's not
used except when generating files in the 'stap' format.
Same applies to your change in tracetool.py when checking the binary/probe/etc
options.
Lluis
--
"And it's much the same thing with knowledge, for whenever you learn
something new, the whole world becomes that much richer."
-- The Princess of Pure Reason, as told by Norton Juster in The Phantom
Tollbooth
- [Qemu-devel] [RFC PATCH v2 0/8] Rewrite tracetool using python modules, Lluís Vilanova, 2012/03/26
- [Qemu-devel] [RFC PATCH v2 1/8] tracetool: Rewrite infrastructure as python modules, Lluís Vilanova, 2012/03/26
- Re: [Qemu-devel] [RFC PATCH v2 1/8] tracetool: Rewrite infrastructure as python modules, Alon Levy, 2012/03/27
- Re: [Qemu-devel] [RFC PATCH v2 1/8] tracetool: Rewrite infrastructure as python modules, Alon Levy, 2012/03/27
- [Qemu-devel] [PATCH] tracetool.py: always pass --binary, --target-arch, --target-type, Alon Levy, 2012/03/27
- Re: [Qemu-devel] [PATCH] tracetool.py: always pass --binary, --target-arch, --target-type,
Lluís Vilanova <=
- Re: [Qemu-devel] [PATCH] tracetool.py: always pass --binary, --target-arch, --target-type, Alon Levy, 2012/03/28
- Re: [Qemu-devel] [PATCH] tracetool.py: always pass --binary, --target-arch, --target-type, Lluís Vilanova, 2012/03/28
[Qemu-devel] [RFC PATCH v2 2/8] tracetool: Add module for the 'c' format, Lluís Vilanova, 2012/03/26
[Qemu-devel] [RFC PATCH v2 3/8] tracetool: Add module for the 'h' format, Lluís Vilanova, 2012/03/26
[Qemu-devel] [RFC PATCH v2 4/8] tracetool: Add support for the 'stderr' backend, Lluís Vilanova, 2012/03/26
[Qemu-devel] [RFC PATCH v2 5/8] tracetool: Add support for the 'simple' backend, Lluís Vilanova, 2012/03/26
[Qemu-devel] [RFC PATCH v2 6/8] tracetool: Add support for the 'ust' backend, Lluís Vilanova, 2012/03/26
[Qemu-devel] [RFC PATCH v2 8/8] tracetool: Add MAINTAINERS info, Lluís Vilanova, 2012/03/26
[Qemu-devel] [RFC PATCH v2 7/8] tracetool: Add support for the 'dtrace' backend, Lluís Vilanova, 2012/03/26