Re: [Qemu-devel] [PATCH V3 05/12] Add helper functions for MIPS DSP Arithmetic instructions

[Jia Liu]

On Wed, Mar 28, 2012 at 12:03 AM, Richard Henderson <address@hidden> wrote:
> On 03/27/12 02:24, Jia Liu wrote:
>> +DEF_HELPER_FLAGS_2(addq_ph, TCG_CALL_CONST | TCG_CALL_PURE, i32, i32, i32)
>> +DEF_HELPER_FLAGS_2(addq_s_ph, TCG_CALL_CONST | TCG_CALL_PURE, i32, i32, i32)
>> +DEF_HELPER_FLAGS_2(addq_s_w, TCG_CALL_CONST | TCG_CALL_PURE, i32, i32, i32)
>> +DEF_HELPER_FLAGS_2(addu_qb, TCG_CALL_CONST | TCG_CALL_PURE, i32, i32, i32)
>
> As mentioned in the first mail, those of these functions that can set
> bits in DSPControl cannot be TCG_CALL_CONST | TCG_CALL_PURE.  There are
> still plenty of these that *are* pure functions though.
>

Thanks, I'll check it.

>
> r~

Regards,
Jia.