[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH trivial] trace-events: don't use dtrace reserved
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH trivial] trace-events: don't use dtrace reserved words in and next |
Date: |
Wed, 28 Mar 2012 14:35:21 +0100 |
On Wed, Mar 28, 2012 at 2:33 PM, Alon Levy <address@hidden> wrote:
> On Wed, Mar 28, 2012 at 03:16:34PM +0200, Alon Levy wrote:
>> On Wed, Mar 28, 2012 at 01:55:49PM +0100, Stefan Hajnoczi wrote:
>> > On Wed, Mar 28, 2012 at 8:55 AM, Alon Levy <address@hidden> wrote:
>> > > ---
>> > > trace-events | 4 ++--
>> > > 1 file changed, 2 insertions(+), 2 deletions(-)
>> >
>> > We're always going to struggle with new trace events that add reserved
>> > keywords. Fixing up trace-events is going to be an ongoing task so
>> > I'd like to also see tracetool automatically modify keywords 'next' ->
>> > 'next_'. Do you want to send a patch to do that instead?
>>
>
> hmm, I changed to _next, not next_, if you'd like to change that and
> commit I don't mind.
Thanks. next_ can be a little safer when languages reserve
identifiers starting with '_'. I can tweak it.
Stefan
- [Qemu-devel] [PATCH trivial] trace-events: don't use dtrace reserved words in and next, Alon Levy, 2012/03/28
- Re: [Qemu-devel] [PATCH trivial] trace-events: don't use dtrace reserved words in and next, Stefan Hajnoczi, 2012/03/28
- Re: [Qemu-devel] [PATCH trivial] trace-events: don't use dtrace reserved words in and next, Alon Levy, 2012/03/28
- [Qemu-devel] [PATCH 1/2] tracetool: dtrace: handle in and next reserved words, Alon Levy, 2012/03/28
- [Qemu-devel] [PATCH 2/2] tracetool: dtrace: warn on reserved word usage, Alon Levy, 2012/03/28
- Re: [Qemu-devel] [PATCH 1/2] tracetool: dtrace: handle in and next reserved words, Lee Essen, 2012/03/28
- Re: [Qemu-devel] [PATCH 1/2] tracetool: dtrace: handle in and next reserved words, Eric Blake, 2012/03/28
- Re: [Qemu-devel] [PATCH 1/2] tracetool: dtrace: handle in and next reserved words, Peter Maydell, 2012/03/28