[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU QOM'ificati
|
From: |
Max Filippov |
|
Subject: |
Re: [Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU QOM'ification |
|
Date: |
Wed, 28 Mar 2012 17:46:48 +0400 |
>> +static void arm_cpu_reset(CPUState *c)
>> +{
>> + ARMCPU *cpu = ARM_CPU(c);
>> + ARMCPUClass *class = ARM_CPU_GET_CLASS(cpu);
>> +
>> + class->parent_reset(c);
>
> I thought we were avoiding 'class' in favour of 'klass'?
I have suggested it once and I can only say it again,
please, call it 'cpu_class'. It is the least surprising name.
--
Thanks.
-- Max
Re: [Qemu-devel] [PATCH v6 2/2] target-arm: Minimalistic CPU QOM'ification, Peter Maydell, 2012/03/28