[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Kick io-thread on qemu_chr_accept_input
|
From: |
Jan Kiszka |
|
Subject: |
Re: [Qemu-devel] [PATCH] Kick io-thread on qemu_chr_accept_input |
|
Date: |
Thu, 29 Mar 2012 14:19:38 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-03-16 14:18, Jan Kiszka wrote:
> On 2012-03-16 14:16, Anthony Liguori wrote:
>> On 03/16/2012 07:25 AM, Jan Kiszka wrote:
>>> Once a chr frontend is able to receive input again, we need to inform
>>> the io-thread about this fact. Otherwise, main_loop_wait may continue to
>>> select without the related backend file descriptor in its set. This can
>>> cause high input latencies if only low-rate events arrive otherwise.
>>>
>>> Signed-off-by: Jan Kiszka<address@hidden>
>>
>> I'm not nacking this patch, but please note that this is a band-aid as not
>> all
>> char devices actually use qemu_chr_accept_input().
>
> Then they have to be fixed. :)
Could you apply the patch in the meantime? It is not band-aid, but a
required base to fix such issues.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux