Re: [Qemu-devel] [PATCH 0/6] usb: descriptor rework.

[Hans de Goede]

Looks good, ack series.

Acked-by: Hans de Goede <address@hidden>

On 03/29/2012 04:48 PM, Gerd Hoffmann wrote:
>    Hi,
>
> This patch series reworks the usb descriptor handling in qemu.  It adds
> a struct for the binary representation of usb descriptors.  It is put
> into use for both generating usb descriptors (for emulated devices) and
> parsing usb descriptors (usb-host driver).  Additionally the usb-host
> parser code has been completely rewritten to simplify the logic and to
> make it more robust.
>
> please review,
>    Gerd
>
> Gerd Hoffmann (6):
>    usb: add USBDescriptor, use for device descriptors.
>    usb: use USBDescriptor for device qualifier descriptors.
>    usb: use USBDescriptor for config descriptors.
>    usb: use USBDescriptor for interface descriptors.
>    usb: use USBDescriptor for endpoint descriptors.
>    usb-host: rewrite usb_linux_update_endp_table
>
>   hw/usb/desc.c       |  126 ++++++++++++++++++----------------
>   hw/usb/desc.h       |   63 +++++++++++++++++
>   hw/usb/host-linux.c |  194 ++++++++++++++++++++++++++------------------------
>   trace-events        |    6 ++
>   4 files changed, 237 insertions(+), 152 deletions(-)