[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] use: fix bit test
From: |
Lai Jiangshan |
Subject: |
Re: [Qemu-devel] [PATCH] use: fix bit test |
Date: |
Tue, 03 Apr 2012 10:52:37 +0800 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc14 Thunderbird/3.1.4 |
On 04/02/2012 05:50 PM, Andreas Färber wrote:
> Am 02.04.2012 08:35, schrieb Lai Jiangshan:
>>
>> use & instead of the wrong &&
>>
>> Signed-off-by: Lai Jiangshan <address@hidden>
>
> Patch looks okay but the subject should probably be fixed to say "usb:"
> when applying. :)
>
Thank you!!
Hi, Gerd,
Does this patch have any problem?
could you merge it with "use:"->"usb:" in the title.
(I think it is not good to send another patch for this)
Thanks
Lai
>
>> ---
>> diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
>> index 73b0c7f..89c2406 100644
>> --- a/hw/usb/hcd-xhci.c
>> +++ b/hw/usb/hcd-xhci.c
>> @@ -502,7 +502,7 @@ static void xhci_irq_update(XHCIState *xhci)
>> int level = 0;
>>
>> if (xhci->iman & IMAN_IP && xhci->iman & IMAN_IE &&
>> - xhci->usbcmd && USBCMD_INTE) {
>> + xhci->usbcmd & USBCMD_INTE) {
>> level = 1;
>> }
>>
>