[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 06/25] qdev: fix -device foo,?
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 06/25] qdev: fix -device foo,? |
Date: |
Tue, 3 Apr 2012 13:15:34 +0200 |
Since most property types do not have a parse property now, this was
broken. Fix it by looking at the setter instead.
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/qdev-monitor.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c
index 4783366..0acfc82 100644
--- a/hw/qdev-monitor.c
+++ b/hw/qdev-monitor.c
@@ -157,7 +157,7 @@ int qdev_device_help(QemuOpts *opts)
* for removal. This conditional should be removed along with
* it.
*/
- if (!prop->info->parse) {
+ if (!prop->info->set) {
continue; /* no way to set it, don't show */
}
error_printf("%s.%s=%s\n", driver, prop->name,
@@ -165,7 +165,7 @@ int qdev_device_help(QemuOpts *opts)
}
if (info->bus_info) {
for (prop = info->bus_info->props; prop && prop->name; prop++) {
- if (!prop->info->parse) {
+ if (!prop->info->set) {
continue; /* no way to set it, don't show */
}
error_printf("%s.%s=%s\n", driver, prop->name,
--
1.7.9.3
- Re: [Qemu-devel] [PATCH 04/25] qom: make Object a type, (continued)
- [Qemu-devel] [PATCH 01/25] qom: add object_class_get_parent, Paolo Bonzini, 2012/04/03
- [Qemu-devel] [PATCH 02/25] qom: add object_child_foreach, Paolo Bonzini, 2012/04/03
- [Qemu-devel] [PATCH 03/25] qom: add class_base_init, Paolo Bonzini, 2012/04/03
- [Qemu-devel] [PATCH 05/25] qom: push type up to Object, Paolo Bonzini, 2012/04/03
- [Qemu-devel] [PATCH 06/25] qdev: fix -device foo,?,
Paolo Bonzini <=
- [Qemu-devel] [PATCH 07/25] qdev: use object_property_print in info qtree, Paolo Bonzini, 2012/04/03
- [Qemu-devel] [PATCH 08/25] qdev: remove qdev_prop_set_defaults, Paolo Bonzini, 2012/04/03
- [Qemu-devel] [PATCH 09/25] qdev: move bus properties to a separate global, Paolo Bonzini, 2012/04/03
- [Qemu-devel] [PATCH 10/25] qdev: do not propagate properties to subclasses, Paolo Bonzini, 2012/04/03