qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3] Replace bdrv_* to bdrv_aio_* functions in DM


From: Zhi Hui Li
Subject: Re: [Qemu-devel] [PATCH v3] Replace bdrv_* to bdrv_aio_* functions in DMA mode in fdc.c.
Date: Tue, 03 Apr 2012 19:53:23 +0800
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.28) Gecko/20120313 Thunderbird/3.1.20


I think what you say up is right, I will correct them, thank you very much!

+        bdrv_aio_readv(cur_drv->bs, fd_sector(cur_drv),
+&fdctrl->qiov, fdc_sector_num, fdctrl_read_DMA_cb, opaque_cb);
+        return dma_len;

Should be return 0 since we haven't completed I/O yet.

Stefan



I think the return value is not used not, so no matter what is returned it not necessary.

if set the dma_len = 0, when call void DMA_set_return(int nret)
function will return the real value;

:)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]