[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5] sheepdog: implement SD_OP_FLUSH_VDI operatio
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v5] sheepdog: implement SD_OP_FLUSH_VDI operation |
Date: |
Wed, 04 Apr 2012 11:20:04 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120316 Thunderbird/11.0 |
Am 04.04.2012 10:58, schrieb Liu Yuan:
> Hi kevin,
>
> On 04/04/2012 04:53 PM, Kevin Wolf wrote:
>
>> I can update it in my queue, no problem there.
>>
>> But I diffed this against v4 and it doesn't seem to have any changes,
>> except in the context of two hunks. Are you sure that you didn't do the
>> fixes in a separate commit or send the wrong patch or something like that?
>
>
> V5 patch just reordered some of lines in sd_open() see below:
> [...]
>
> s->{addr,port} is initilized in find_vdi_name(), so flush_fd should be
> initilized after it.
Yes, of course. It seems to be still too early in the morning...
Thanks, I updated the patch in my queue.
Kevin
- Re: [Qemu-devel] RE. [PATCH] sheepdog: fix send req helpers, (continued)
- Re: [Qemu-devel] [PATCH v3] sheepdog: implement SD_OP_FLUSH_VDI operation, MORITA Kazutaka, 2012/04/03
- [Qemu-devel] [PATCH v4] sheepdog: implement SD_OP_FLUSH_VDI operation, Liu Yuan, 2012/04/03
- [Qemu-devel] [PATCH v4 UPDATE] sheepdog: implement SD_OP_FLUSH_VDI operation, Liu Yuan, 2012/04/03
- Re: [Qemu-devel] [PATCH v4 UPDATE] sheepdog: implement SD_OP_FLUSH_VDI operation, MORITA Kazutaka, 2012/04/03
- Re: [Qemu-devel] [PATCH v4 UPDATE] sheepdog: implement SD_OP_FLUSH_VDI operation, Kevin Wolf, 2012/04/03
- [Qemu-devel] [PATCH v5] sheepdog: implement SD_OP_FLUSH_VDI operation, Liu Yuan, 2012/04/03
- Re: [Qemu-devel] [PATCH v5] sheepdog: implement SD_OP_FLUSH_VDI operation, Kevin Wolf, 2012/04/04
- Re: [Qemu-devel] [PATCH v5] sheepdog: implement SD_OP_FLUSH_VDI operation, Liu Yuan, 2012/04/04
- Re: [Qemu-devel] [PATCH v5] sheepdog: implement SD_OP_FLUSH_VDI operation,
Kevin Wolf <=
Re: [Qemu-devel] [PATCH] sheepdog: implement SD_OP_FLUSH_VDI operation, Christoph Hellwig, 2012/04/20