[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] target-xtensa: fix tb invalidation for IBRE
From: |
Max Filippov |
Subject: |
Re: [Qemu-devel] [PATCH 4/4] target-xtensa: fix tb invalidation for IBREAK and LOOP |
Date: |
Sat, 7 Apr 2012 20:52:23 +0400 |
>> Instruction breakpoint/zero overhead loop handling code is built into
>> TBs pointed to by IBREAKA/LEND SRs. When these or related SRs get
>> changed TBs at virtual addresses corresponding to their old and their
>> new values must be invalidated.
>>
>> Virtual address range is passed to the tb_invalidate_phys_page_range,
>> which is incorrect in system emulation mode.
>>
>> To fix it use guest TLB/MMU to translate virtual address to physical
>> address.
>>
>> However the guest may not have virtual-to-physical mapping at the moment
>> of IBREAKA/LEND change, thus this fix is not 100% accurate.
>>
>> Signed-off-by: Max Filippov <address@hidden>
>> ---
>> exec-all.h | 1 +
>> exec.c | 9 ++++++---
>> target-xtensa/op_helper.c | 29 ++++++++++++++++++-----------
>> 3 files changed, 25 insertions(+), 14 deletions(-)
> [snip]
>
> In addition to the breakage reported by Blue, a subject starting with
> "target-xtensa: " gives the impression that it only affects Xtensa.
> Please split it in two and wait for an Acked-by on the exec part before
> including it in an Xtensa PULL.
You're right, sorry about that.
--
Thanks.
-- Max
- [Qemu-devel] [PULL 0/4] target-xtensa queue, Max Filippov, 2012/04/05
- [Qemu-devel] [PATCH 1/4] target-xtensa: Move helpers.h to helper.h, Max Filippov, 2012/04/05
- [Qemu-devel] [PATCH 2/4] target-xtensa: improve unit tests debugging, Max Filippov, 2012/04/05
- [Qemu-devel] [PATCH 3/4] target-xtensa: add test for LEND invalidation, Max Filippov, 2012/04/05
- [Qemu-devel] [PATCH 4/4] target-xtensa: fix tb invalidation for IBREAK and LOOP, Max Filippov, 2012/04/05
- Re: [Qemu-devel] [PULL 0/4] target-xtensa queue, Blue Swirl, 2012/04/07