Re: [Qemu-devel] [PATCH v8 0/8] Rewrite tracetool using python modules

[Stefan Hajnoczi]

On Tue, Apr 03, 2012 at 08:47:33PM +0200, Lluís Vilanova wrote:
> A full rewrite of the tracetool script using per-format and per-backend 
> modules,
> so that it's easier to read and extend it in the future.
> 
> Signed-off-by: Lluís Vilanova <address@hidden>
> ---
> NOTE: This series applies in current master, ignoring the "Rewrite tracetool
>       using python" series.
> 
> Changes in v8:
> 
> * Backport minor fix to 'tracetool.format.h.nop'.
> 
> Changes in v7:
> 
> * Fix backend/format to module name translations.
> 
> Changes in v6:
> 
> * Separate line parsing from object construction in 'tracetool.Event' and
>   'tracetool.Arguments'.
> 
> Changes in v5:
> 
> * De-uglify the uses of 'tracetool.out' by adding support for mapping 
> variables.
> * Remove stale PUBLIC variables in backend modules.
> 
> Changes in v4:
> 
> * Some code cleanups according to comments from Stefan Hajnoczi:
> ** Removed the "public backend" concept (will be introduced only when 
> necessary).
> ** Moved 'tracetool.generate' from "kwargs" to explicitly named arguments.
> 
> Changes in v3:
> 
> * Some minor fixes according to comments from Alon Levy:
> ** Fixed some rogue tabs.
> ** Fixed definition of '_SCRIPT' in "tracetool.py".
> ** Fixed some documentation.
> ** Defensively treat results from 'try_import' in 'get_list'.
> ** Fixed the no-arguments case in 'tracetool.backend.dtrace.d'.
> ** Fixed the commandline checks for the "stap" format.
> ** Added '__repr__' methods for both Event and Arguments objects.
> 
> 
> Changes in v2:
> 
> * Fixed a strange import error.
> * Add a pointer to 'tracetool.out' in the format and backend documentation.
> 
> Lluís Vilanova (8):
>       tracetool: Rewrite infrastructure as python modules
>       tracetool: Add module for the 'c' format
>       tracetool: Add module for the 'h' format
>       tracetool: Add support for the 'stderr' backend
>       tracetool: Add support for the 'simple' backend
>       tracetool: Add support for the 'ust' backend
>       tracetool: Add support for the 'dtrace' backend
>       tracetool: Add MAINTAINERS info
> 
> 
>  MAINTAINERS                           |    2 
>  Makefile.objs                         |    6 
>  Makefile.target                       |   13 -
>  configure                             |    4 
>  scripts/tracetool                     |  648 
> ---------------------------------
>  scripts/tracetool.py                  |  138 +++++++
>  scripts/tracetool/__init__.py         |  271 ++++++++++++++
>  scripts/tracetool/backend/__init__.py |  111 ++++++
>  scripts/tracetool/backend/dtrace.py   |   97 +++++
>  scripts/tracetool/backend/simple.py   |   55 +++
>  scripts/tracetool/backend/stderr.py   |   56 +++
>  scripts/tracetool/backend/ust.py      |   90 +++++
>  scripts/tracetool/format/__init__.py  |   99 +++++
>  scripts/tracetool/format/c.py         |   20 +
>  scripts/tracetool/format/d.py         |   20 +
>  scripts/tracetool/format/h.py         |   45 ++
>  scripts/tracetool/format/stap.py      |   20 +
>  17 files changed, 1036 insertions(+), 659 deletions(-)
>  delete mode 100755 scripts/tracetool
>  create mode 100755 scripts/tracetool.py
>  create mode 100644 scripts/tracetool/__init__.py
>  create mode 100644 scripts/tracetool/backend/__init__.py
>  create mode 100644 scripts/tracetool/backend/dtrace.py
>  create mode 100644 scripts/tracetool/backend/simple.py
>  create mode 100644 scripts/tracetool/backend/stderr.py
>  create mode 100644 scripts/tracetool/backend/ust.py
>  create mode 100644 scripts/tracetool/format/__init__.py
>  create mode 100644 scripts/tracetool/format/c.py
>  create mode 100644 scripts/tracetool/format/d.py
>  create mode 100644 scripts/tracetool/format/h.py
>  create mode 100644 scripts/tracetool/format/stap.py

Excellent, thank you!

There was a conflict qemu.git/master and Patch 1 which I have tried to
resolve.  I also added commit descriptions to the first and last patches
to capture the rationale behind these changes.

Please check the tracing tree to confirm that you are happy with the
merge:

https://github.com/stefanha/qemu/commits/trivial-patches

Thanks,
Stefan