[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] error.c: don't return value for void function
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] error.c: don't return value for void function |
Date: |
Mon, 16 Apr 2012 10:58:46 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
Il 16/04/2012 09:32, Amos Kong ha scritto:
> It is invalid to return a value from a function
> returning void.
>
> Signed-off-by: Amos Kong <address@hidden>
> ---
> error.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/error.c b/error.c
> index d3455ab..a52b771 100644
> --- a/error.c
> +++ b/error.c
> @@ -93,7 +93,7 @@ QDict *error_get_data(Error *err)
> void error_set_field(Error *err, const char *field, const char *value)
> {
> QDict *dict = qdict_get_qdict(err->obj, "data");
> - return qdict_put(dict, field, qstring_from_str(value));
> + qdict_put(dict, field, qstring_from_str(value));
> }
>
> void error_free(Error *err)
Reviewed-by: Paolo Bonzini <address@hidden>