Re: [Qemu-devel] [PATCH] qemu-ga: generate missing stubs for fsfreeze

[Michael Roth]

On Tue, Apr 17, 2012 at 11:44:39AM -0300, Luiz Capitulino wrote:
> On Fri, 13 Apr 2012 21:07:36 -0500
> Michael Roth <address@hidden> wrote:
> 
> > When linux-specific commands (including guest-fsfreeze-*) were consolidated
> > under defined(__linux__), we forgot to account for the case where
> > defined(__linux__) && !defined(FIFREEZE). As a result stubs are no longer
> > being generated on linux hosts that don't have FIFREEZE support. Fix
> > this.
> > 
> > Signed-off-by: Michael Roth <address@hidden>
> 
> Looks good to me, but I'm honestly a bit confused with the number of ifdefs we
> have in this file. I think it's possible to re-organize them, but maybe it's
> best to move the linux specific stuff to its own file.
> 

Yah, it was actually pretty nice and organized prior to this patch. Just 1
place/#ifdef __linux__ for determining whether to implement or stub. The
fsfreeze stuff is unfortunate because it's both linux-specific and
distro-dependent, so if we moved linux-specific commands to another file
we'd still need to include an #ifdef for fsfreeze. Plus I'd really like
to avoid doing anything that would encourage linux-specific
implementations. Needing to wrap your code in #ifdefs is punishment of sorts :P
Plus I think over time all the current RPCs other than fsfreeze can be
implemented for non-linux, so this is technically the right place for them.