[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support |
Date: |
Thu, 19 Apr 2012 10:43:51 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
Il 19/04/2012 10:19, Zhi Yong Wu ha scritto:
>> >
>> > 2) The series uses vhost-scsi unconditionally, as far as I can tell. So
> Perhaps there're some cleanup work to do, but it use vhost-scsi
> *conditionally*. In virtio_scsi_init(), you can see the code as below:
> if (s->vhost_scsi) {
> s->vdev.set_status = virtio_scsi_set_status;
> }
> As you have seen, virtio_scsi_set_status will be used to trigger
> vhost_scsi function.
Ok, I was not sure if that was enough.
>> Even if it actually worked, you need to mention what happens if you
>> configure SCSI devices on the same virtio-scsi driver that uses vhost.
> OK, i will do this in next version.
You probably need to stop exposing the SCSI bus altogether if vhost is
chosen.
Paolo
- [Qemu-devel] [PATCH 14/16] vhost-scsi: enable vhost notifiers for multiple queues, (continued)
- [Qemu-devel] [PATCH 14/16] vhost-scsi: enable vhost notifiers for multiple queues, zwu . kernel, 2012/04/18
- [Qemu-devel] [PATCH 09/16] virtio-pci: support host notifiers in TCG mode, zwu . kernel, 2012/04/18
- [Qemu-devel] [PATCH 11/16] vhost-scsi: add -vhost-scsi host device, zwu . kernel, 2012/04/18
- [Qemu-devel] [PATCH 08/16] notifier: add validity check and notify function, zwu . kernel, 2012/04/18
- [Qemu-devel] [PATCH 15/16] vhost-scsi: move some definitions to its header file, zwu . kernel, 2012/04/18
- [Qemu-devel] [PATCH 10/16] virtio-pci: check that event notification worked, zwu . kernel, 2012/04/18
- [Qemu-devel] [PATCH 16/16] vhost-scsi: clear endpoint on stopped, zwu . kernel, 2012/04/18
- Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support, Paolo Bonzini, 2012/04/19
- Re: [Qemu-devel] [PATCH 00/16] QEMU vhost-scsi support, Anthony Liguori, 2012/04/19