Re: [Qemu-devel] [PATCH 2/3] block: wait for job callback in block_job_cancel_sync

[Paolo Bonzini]

Il 19/04/2012 12:31, Stefan Hajnoczi ha scritto:
>>  void block_job_cancel(BlockJob *job)
>>  {
>> +    /* Complete all guest I/O before cancelling the job, so that if the
>> +     * job chooses to complete itself it will do so with a consistent
>> +     * view of the disk.
>> +     */
>> +    bdrv_drain_all();
>>      job->cancelled = true;
>> +    if (job->co && !job->busy) {
>> +        qemu_coroutine_enter(job->co, NULL);
>> +    }
>>  }
> 
> block_job_cancel() is not supposed to block.  Now it will wait however
> long it takes to complete in-flight I/O.

You're right...  let me see if we can fix it otherwise. :/

Paolo