|
From: | Stefan Weil |
Subject: | Re: [Qemu-devel] [PATCH] linux-user: Fix undefined HOST_LONG_SIZE on PPC hosts |
Date: | Thu, 19 Apr 2012 21:25:33 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.28) Gecko/20120313 Thunderbird/3.1.20 |
Am 19.04.2012 16:47, schrieb Peter Maydell:
On 19 April 2012 15:23, Alexander Graf <address@hidden> wrote:On my PPC host, HOST_LONG_SIZE is not defined even after running configure. Use the normal C way of determining the long size instead. #elif defined(HOST_PPC) - return HOST_LONG_SIZE; + return sizeof(long); #elseHOST_LONG_SIZE was removed by Stefan in commit 9c6ecf; it looks like this PPC-only use was accidentally omitted. For consistency with that commit and how we handle TYPE_LONG in this function, it would be better to use 'sizeof(void *)' here I think. -- PMM
The patch which added this HOST_LONG_SIZE was written before my patch which removed HOST_LONG_SIZE, but it was committed to QEMU master _after_ my patch. As Peter wrote, sizeof(void *) would be a good replacement for PPC(64) here. Regards, Stefan W.
[Prev in Thread] | Current Thread | [Next in Thread] |