[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 1/7] error.c: don't return value for void function
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 1/7] error.c: don't return value for void function |
Date: |
Fri, 20 Apr 2012 13:52:30 +0100 |
From: Amos Kong <address@hidden>
It is invalid to return a value from a function
returning void.
[C99 6.8.6.4 says "A return statement with an expression shall not
appear in a function whose return type is void" but gcc 4.6.3 with QEMU
compile flags does not complain. It's still worth fixing this. Stefan]
Signed-off-by: Amos Kong <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
error.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/error.c b/error.c
index d3455ab..a52b771 100644
--- a/error.c
+++ b/error.c
@@ -93,7 +93,7 @@ QDict *error_get_data(Error *err)
void error_set_field(Error *err, const char *field, const char *value)
{
QDict *dict = qdict_get_qdict(err->obj, "data");
- return qdict_put(dict, field, qstring_from_str(value));
+ qdict_put(dict, field, qstring_from_str(value));
}
void error_free(Error *err)
--
1.7.9.5
- [Qemu-devel] [PULL 0/7] Trivial patches for 14 to 20 April 2012, Stefan Hajnoczi, 2012/04/20
- [Qemu-devel] [PATCH 4/7] pflash_cfi01: remove redundant line, Stefan Hajnoczi, 2012/04/20
- [Qemu-devel] [PATCH 5/7] spice-qemu-char.c: Show what name is unsupported, Stefan Hajnoczi, 2012/04/20
- [Qemu-devel] [PATCH 2/7] fix block_job_set_speed name in documentation, Stefan Hajnoczi, 2012/04/20
- [Qemu-devel] [PATCH 6/7] e1000: Fix spelling (segmentaion -> segmentation) in debug output, Stefan Hajnoczi, 2012/04/20
- [Qemu-devel] [PATCH 3/7] qxl: Add missing GCC_FMT_ATTR and fix format specifier, Stefan Hajnoczi, 2012/04/20
- [Qemu-devel] [PATCH 1/7] error.c: don't return value for void function,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 7/7] Add .gitignore for tests/, Stefan Hajnoczi, 2012/04/20