Re: [Qemu-devel] [PATCH v2 0/4] QOM'ify Motorola 68k CPU

[Laurent Vivier]

Le dimanche 22 avril 2012 à 01:17 +0200, Laurent Vivier a écrit :
> Le samedi 21 avril 2012 à 08:08 +0200, Andreas Färber a écrit :
> > Am 15.04.2012 05:10, schrieb Andreas Färber:
> > > Hello,
> > > 
> > > This series splits up my m68k QOM'ification patch from the qom-cpu-others 
> > > RFC series.
> > > CPU models are now modelled as subclasses with their own initfns, leaving 
> > > the
> > > setting of feature flags imperative.
> > > 
> > > Please review and apply.
> > 
> > Ping!
> > 
> > Laurent, did you get around to reviewing this or testing your tree on
> > top? Hard Freeze for 1.1 is coming up (also if you have any fixes to
> > upstream yourself, obviously).
> 
> I'm sorry,  I can't test it with my branch: my branch is based on 1.0.1
> and when I rebase it something else is broken, so I can't test... and I
> don't have any time to do more.
> 
> Anyway, patches seem OK.
> 
> Reviewed-by: Laurent Vivier <address@hidden>

I've been able to test it, so:

Tested-by: Laurent Vivier <address@hidden>

> 
> > If there are no comments, I'll send out a PULL mid next week.
> > 
> > Andreas
> > 
> > > 
> > > Available from:
> > > git://github.com/afaerber/qemu-cpu.git qom-cpu-m68k.v2
> > > https://github.com/afaerber/qemu-cpu/commits/qom-cpu-m68k.v2
> > > 
> > > Regards,
> > > Andreas
> > > 
> > > Cc: Paul Brook <address@hidden>
> > > Cc: Laurent Vivier <address@hidden>
> > > 
> > > v1 -> v2:
> > > * Split off from qom-cpu-others series, rebased and split into multiple 
> > > steps.
> > > * Update argument/variable naming to avoid "klass".
> > > * Instead of transforming feature flag setup into declarative M68kCPUInfo 
> > > fields
> > >   move the original code into initfns, following Peter's model for ARM.
> > >   As a side effect, we can't move cpu_reset() into the main initfn.
> > > 
> > > Andreas Färber (4):
> > >   target-m68k: QOM'ify CPU
> > >   target-m68k: QOM'ify CPU reset
> > >   target-m68k: Start QOM'ifying CPU init
> > >   target-m68k: Add QOM CPU subclasses
> > > 
> > >  Makefile.target       |    1 +
> > >  target-m68k/cpu-qom.h |   70 ++++++++++++++++++++
> > >  target-m68k/cpu.c     |  170 
> > > +++++++++++++++++++++++++++++++++++++++++++++++++
> > >  target-m68k/cpu.h     |    3 +-
> > >  target-m68k/helper.c  |  159 
> > > +++++++++++++++-------------------------------
> > >  5 files changed, 294 insertions(+), 109 deletions(-)
> > >  create mode 100644 target-m68k/cpu-qom.h
> > >  create mode 100644 target-m68k/cpu.c
> > > 
> > 
> > 
> 
> 
>