[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [Bug 986770] Re: Oops: spice configured but not active
From: |
Alon Levy |
Subject: |
[Qemu-devel] [Bug 986770] Re: Oops: spice configured but not active |
Date: |
Mon, 23 Apr 2012 10:24:26 -0000 |
Seems commit ad1be89948f88e89708b04ccd782456ccec3a6f0 from qemu needs to
go in to qemu-kvm.
Could you try that and report if it fixes the issue for you?
commit ad1be89948f88e89708b04ccd782456ccec3a6f0
Author: Alon Levy <address@hidden>
Date: Wed Mar 14 20:33:37 2012 +0200
spice: fix broken initialization
Commit 1b71f7c14fab6f00c2680d4489fbee7baf796e4f moved MODULE_INIT_QOM to
way before MODULE_INIT_MACHINE, thereby breaking assumptions made in
spice-core.c which registered both a type initializer and a machine
intializer.
This fix removes the type registration, and replaces it with calling
qemu_spice_init in vl.c after command line parsing (second pass) is
done, and after timers are armed, required by spice server.
Signed-off-by: Alon Levy <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 80535b6..a468524 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -554,7 +554,7 @@ void qemu_spice_init(void)
qemu_thread_get_self(&me);
- if (!opts) {
+ if (!opts) {
return;
}
port = qemu_opt_get_number(opts, "port", 0);
@@ -787,10 +787,3 @@ static void spice_register_config(void)
qemu_add_opts(&qemu_spice_opts);
}
machine_init(spice_register_config);
-
-static void spice_register_types(void)
-{
- qemu_spice_init();
-}
-
-type_init(spice_register_types)
diff --git a/vl.c b/vl.c
index bd95539..eeb634b 100644
--- a/vl.c
+++ b/vl.c
@@ -3369,6 +3369,11 @@ int main(int argc, char **argv, char **envp)
exit(1);
}
+#ifdef CONFIG_SPICE
+ /* spice needs the timers to be initialized by this point */
+ qemu_spice_init();
+#endif
+
if (icount_option && (kvm_enabled() || xen_enabled())) {
fprintf(stderr, "-icount is not allowed with kvm or xen\n");
exit(1);
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/986770
Title:
Oops: spice configured but not active
Status in QEMU:
New
Bug description:
with latest qemu-kvm from git i have following problem:
/usr/bin/kvm -daemonize -smp 4 -cpu host -vga qxl -enable-kvm -m 4096
-localtime -drive
file=/home/sss/vm/win_xp/tmp_sys.img,if=virtio,media=disk,cache=none -drive
file=/home/sss/vm/data.img,if=virtio,media=disk,cache=none -net
nic,vlan=0,model=virtio,macaddr=6a:94:fc:2d:b9:04 -net
tap,vlan=0,ifname=vtap0,script=no -usb -usbdevice tablet -name "Windows XP qt"
-spice port=5934,addr=127.0.0.1,ipv4,playback-compression=off,disable-ticketing
-monitor telnet::4448,server,nowait -device virtio-serial -chardev
spicevmc,id=vdagent,name=vdagent -device
virtserialport,chardev=vdagent,name=com.redhat.spice.0 -balloon virtio
qemu-system-x86_64: Oops: spice configured but not active
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/986770/+subscriptions
[Prev in Thread] |
Current Thread |
[Next in Thread] |