[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC] qxl: don't panic on phys2virt
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [RFC] qxl: don't panic on phys2virt |
Date: |
Tue, 24 Apr 2012 12:22:34 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.3) Gecko/20120307 Thunderbird/10.0.3 |
On 03/30/12 21:27, Alon Levy wrote:
> On Fri, Mar 30, 2012 at 10:09:42AM +0200, Gerd Hoffmann wrote:
>> On 03/29/12 22:56, Alon Levy wrote:
>>> Issues a qxl_guest_bug from qxl_phys2virt. Everywhere else will fail.
>>
>> Nice start (there are more guest-triggerable asserts to be fixed this way).
>>
>>> qxl_phys2virt requires an additional argument because all it's possible
>>> return values are legit (well, I could use the fact it returns a pointer
>>> so it should be word aligned but I don't want to go there, this is
>>> totally internal).
>>
>> Really? What is bad with returning and checking for NULL? Guest
>> memslots are backed by guest ram and should never ever resolve to a NULL
>> pointer in qemu's process address space.
>
> phys2virt actually returns an offset, not a real pointer iirc. I'll
> check it again.
It is a real pointer.
Do you have an updated patch?
cheers,
Gerd
- Re: [Qemu-devel] [RFC] qxl: don't panic on phys2virt,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH 1/9] hw/qxl.c: qxl_phys2virt: replace panics with guest_bug, Alon Levy, 2012/04/25
- [Qemu-devel] [PATCH 2/9] qxl: check for NULL return from qxl_phys2virt, Alon Levy, 2012/04/25
- [Qemu-devel] [PATCH 3/9] qxl: replace panic with guest bug in qxl_track_command, Alon Levy, 2012/04/25
- [Qemu-devel] [PATCH 4/9] qxl: fix > 80 chars line, Alon Levy, 2012/04/25
- [Qemu-devel] [PATCH 5/9] qxl: don't abort on guest trigerrable ring indices mismatch, Alon Levy, 2012/04/25
- [Qemu-devel] [PATCH 6/9] qxl: cleanup s/__FUNCTION__/__func__/, Alon Levy, 2012/04/25
- [Qemu-devel] [PATCH 7/9] qxl: interface_notify_update: remove guest trigerrable abort, Alon Levy, 2012/04/25