[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv2 2/3] virtio: add missing mb() on enable notifi
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCHv2 2/3] virtio: add missing mb() on enable notification |
|
Date: |
Tue, 24 Apr 2012 16:03:16 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
Il 23/04/2012 15:19, Michael S. Tsirkin ha scritto:
> @@ -694,7 +698,7 @@ static bool vring_notify(VirtIODevice *vdev, VirtQueue
> *vq)
> uint16_t old, new;
> bool v;
> /* We need to expose used array entries before checking used event. */
> - mb();
> + smp_mb();
This mb() is not in upstream QEMU, only in qemu-kvm.
Paolo
[Qemu-devel] [PATCHv2 2/3] virtio: add missing mb() on enable notification, Michael S. Tsirkin, 2012/04/23
- Re: [Qemu-devel] [PATCHv2 2/3] virtio: add missing mb() on enable notification,
Paolo Bonzini <=
[Qemu-devel] [PATCHv2 3/3] virtio: order index/descriptor reads, Michael S. Tsirkin, 2012/04/23
- Re: [Qemu-devel] [PATCHv2 3/3] virtio: order index/descriptor reads, Paolo Bonzini, 2012/04/24
- Re: [Qemu-devel] [PATCHv2 3/3] virtio: order index/descriptor reads, Michael S. Tsirkin, 2012/04/24
- Re: [Qemu-devel] [PATCHv2 3/3] virtio: order index/descriptor reads, Paolo Bonzini, 2012/04/24
- Re: [Qemu-devel] [PATCHv2 3/3] virtio: order index/descriptor reads, Michael S. Tsirkin, 2012/04/24
- Re: [Qemu-devel] [PATCHv2 3/3] virtio: order index/descriptor reads, Paolo Bonzini, 2012/04/24
- Re: [Qemu-devel] [PATCHv2 3/3] virtio: order index/descriptor reads, Michael S. Tsirkin, 2012/04/24
- Re: [Qemu-devel] [PATCHv2 3/3] virtio: order index/descriptor reads, Paolo Bonzini, 2012/04/24
Re: [Qemu-devel] [PATCHv2 0/3] virtio: fix memory access races, Stefan Hajnoczi, 2012/04/24