Re: [Qemu-devel] [PATCH 12/21] pc: add back PCI.rombar compat property

[Michael S. Tsirkin]

On Wed, May 02, 2012 at 01:31:04PM +0200, Paolo Bonzini wrote:
> This was erroneously dropped in d6c730086cbf24382eb8cff25551798769edfd84.
> 
> Cc: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>

Yes I think it's a mistake, however we had:
-        },{
-            .driver   = "PCI",
-            .property = "rombar",
-            .value    = stringify(0),
-        },{

and not TYPE_PCI_DEVICE.

So let's put it back the way it was?

> ---
>  hw/pc_piix.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/hw/pc_piix.c b/hw/pc_piix.c
> index ef6afb1..15a62ef 100644
> --- a/hw/pc_piix.c
> +++ b/hw/pc_piix.c
> @@ -523,6 +523,10 @@ static QEMUMachine pc_machine_v0_12 = {
>              .driver   = "virtio-blk-pci",\
>              .property = "vectors",\
>              .value    = stringify(0),\
> +        },{\
> +            .driver   = TYPE_PCI_DEVICE,\
> +            .property = "rombar",\
> +            .value    = stringify(0),\
>          }
>  
>  static QEMUMachine pc_machine_v0_11 = {
> -- 
> 1.7.9.3
>