[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/21] pc: add back PCI.rombar compat property
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 12/21] pc: add back PCI.rombar compat property |
Date: |
Wed, 2 May 2012 14:38:57 +0300 |
On Wed, May 02, 2012 at 01:31:04PM +0200, Paolo Bonzini wrote:
> This was erroneously dropped in d6c730086cbf24382eb8cff25551798769edfd84.
>
> Cc: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
Yes I think it's a mistake, however we had:
- },{
- .driver = "PCI",
- .property = "rombar",
- .value = stringify(0),
- },{
and not TYPE_PCI_DEVICE.
So let's put it back the way it was?
> ---
> hw/pc_piix.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/hw/pc_piix.c b/hw/pc_piix.c
> index ef6afb1..15a62ef 100644
> --- a/hw/pc_piix.c
> +++ b/hw/pc_piix.c
> @@ -523,6 +523,10 @@ static QEMUMachine pc_machine_v0_12 = {
> .driver = "virtio-blk-pci",\
> .property = "vectors",\
> .value = stringify(0),\
> + },{\
> + .driver = TYPE_PCI_DEVICE,\
> + .property = "rombar",\
> + .value = stringify(0),\
> }
>
> static QEMUMachine pc_machine_v0_11 = {
> --
> 1.7.9.3
>
- Re: [Qemu-devel] [PATCH 11/21] qdev: move bus properties to abstract superclasses, (continued)
- Re: [Qemu-devel] [PATCH 11/21] qdev: move bus properties to abstract superclasses, Paolo Bonzini, 2012/05/02
- Re: [Qemu-devel] [PATCH 11/21] qdev: move bus properties to abstract superclasses, Anthony Liguori, 2012/05/02
- Re: [Qemu-devel] [PATCH 11/21] qdev: move bus properties to abstract superclasses, Paolo Bonzini, 2012/05/02
- Re: [Qemu-devel] [PATCH 11/21] qdev: move bus properties to abstract superclasses, Anthony Liguori, 2012/05/03
- Re: [Qemu-devel] [PATCH 11/21] qdev: move bus properties to abstract superclasses, Paolo Bonzini, 2012/05/03
[Qemu-devel] [PATCH 16/21] qdev: use wrapper for qdev_get_path, Paolo Bonzini, 2012/05/02
[Qemu-devel] [PATCH 20/21] qbus: make child devices links, Paolo Bonzini, 2012/05/02
[Qemu-devel] [PATCH 12/21] pc: add back PCI.rombar compat property, Paolo Bonzini, 2012/05/02
- Re: [Qemu-devel] [PATCH 12/21] pc: add back PCI.rombar compat property,
Michael S. Tsirkin <=
Re: [Qemu-devel] [PATCH 00/21] qbus QOM conversion, rebased on top of my patches, Paolo Bonzini, 2012/05/04
Re: [Qemu-devel] [PATCH 00/21] qbus QOM conversion, rebased on top of my patches, Paolo Bonzini, 2012/05/23