[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/21] pc: add back PCI.rombar compat property
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 12/21] pc: add back PCI.rombar compat property |
|
Date: |
Wed, 02 May 2012 13:41:30 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120425 Thunderbird/12.0 |
Il 02/05/2012 13:38, Michael S. Tsirkin ha scritto:
> On Wed, May 02, 2012 at 01:31:04PM +0200, Paolo Bonzini wrote:
>> This was erroneously dropped in d6c730086cbf24382eb8cff25551798769edfd84.
>>
>> Cc: Michael S. Tsirkin <address@hidden>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>
> Yes I think it's a mistake, however we had:
> - },{
> - .driver = "PCI",
> - .property = "rombar",
> - .value = stringify(0),
> - },{
>
> and not TYPE_PCI_DEVICE.
PCI->TYPE_PCI_DEVICE is required by earlier patches in the series.
Paolo
- Re: [Qemu-devel] [PATCH 11/21] qdev: move bus properties to abstract superclasses, (continued)
[Qemu-devel] [PATCH 16/21] qdev: use wrapper for qdev_get_path, Paolo Bonzini, 2012/05/02
[Qemu-devel] [PATCH 20/21] qbus: make child devices links, Paolo Bonzini, 2012/05/02
[Qemu-devel] [PATCH 12/21] pc: add back PCI.rombar compat property, Paolo Bonzini, 2012/05/02
Re: [Qemu-devel] [PATCH 00/21] qbus QOM conversion, rebased on top of my patches, Paolo Bonzini, 2012/05/04
Re: [Qemu-devel] [PATCH 00/21] qbus QOM conversion, rebased on top of my patches, Paolo Bonzini, 2012/05/23