[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] slirp: Untangle TCPOLEN_* from TCPOPT_*
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH] slirp: Untangle TCPOLEN_* from TCPOPT_* |
|
Date: |
Wed, 02 May 2012 15:40:53 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120421 Thunderbird/12.0 |
Am 02.05.2012 15:24, schrieb Paolo Bonzini:
>> But that would leave Illumos broken.
For the record, reverting would leave whatever Paolo was fixing broken
but would restore Illumos.
> I'd rather apply this one.
>
> Please do. The right solution for 1.2 is to understand the places in which
> slirp cannot use netinet/tcp.h constants (the MSS for example), and
> otherwise use that header.
Jan, should I prepare a mechanical prefix addition as suggested by Blue?
Should we apply this ugly-but-least-intrusive build fix? Or do you have
any other preference or idea?
Andreas