[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Fix legacy device aliases for s390
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] Fix legacy device aliases for s390 |
Date: |
Thu, 03 May 2012 05:05:37 -0400 (EDT) |
> > The usual old fix was to not even compile them in. Why are they in
> > the alias list in the s390 build now?
>
> Because the alias list is in target-independent code.
>
> The old fix was brittle anyway, it dependent on the fact that
> virtio-blk-pci was not part of libhw. A similar trick broke for
> cirrus-vga when it became part of libhw.
>
> Christian fix is correct.
Uhm, Christian fix would have the same problem actually if
virtio-*-pci were to be moved in libhw. IIRC I proposed the
same change on review and Anthony nacked it on these grounds.
You could move the alias list to target-dependent code, though.
Paolo
- [Qemu-devel] [PATCH] Fix legacy device aliases for s390, Christian Borntraeger, 2012/05/03
- Re: [Qemu-devel] [PATCH] Fix legacy device aliases for s390, Alexander Graf, 2012/05/03
- Re: [Qemu-devel] [PATCH] Fix legacy device aliases for s390, Christian Borntraeger, 2012/05/03
- Re: [Qemu-devel] [PATCH] Fix legacy device aliases for s390, Paolo Bonzini, 2012/05/03
- Re: [Qemu-devel] [PATCH] Fix legacy device aliases for s390,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH] Fix legacy device aliases for s390, Alexander Graf, 2012/05/03
- Re: [Qemu-devel] [PATCH] Fix legacy device aliases for s390, Paolo Bonzini, 2012/05/03
- Re: [Qemu-devel] [PATCH] Fix legacy device aliases for s390, Anthony Liguori, 2012/05/03
- Re: [Qemu-devel] [PATCH] Fix legacy device aliases for s390, Alexander Graf, 2012/05/03
- Re: [Qemu-devel] [PATCH] Fix legacy device aliases for s390, Alexander Graf, 2012/05/17
- Re: [Qemu-devel] [PATCH] Fix legacy device aliases for s390, Anthony Liguori, 2012/05/17