[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 23/35] vmstate: port arm cpu
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 23/35] vmstate: port arm cpu |
Date: |
Fri, 4 May 2012 16:37:31 +0100 |
On 4 May 2012 16:28, Juan Quintela <address@hidden> wrote:
> The only other sane approach that I can think is changing:
>
> #define VMSTATE_INT32_V(_f, _s, _v) \
>
> into something like:
>
> VMSTATE_INT32_GENERAL(_f, _s, _v, _getter, _setter)
>
> and then _getter/_setter functions for normal ints the obvious copy this
> uint32_t?
>
> Would that work for you?
Yes, I'd be happy with that approach: it's the general idea of
"here's a function to get/set the value" that I like in the alpha
code, not the specific implementation (which is a bit of an ugly
hack).
-- PMM
- [Qemu-devel] [PATCH 19/35] mips: make tlb an embedded struct instead of a pointer, (continued)
- [Qemu-devel] [PATCH 19/35] mips: make tlb an embedded struct instead of a pointer, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 20/35] mips: bump migration version to 4, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 18/35] mips: make mvp an embedded struct instead of a pointer, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 26/35] vmstate: remove unneeded includes from target-*/machine.c, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 24/35] vmstate: all cpus converted, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 29/35] vmstate: Add copyright info for lm32 processor, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 21/35] vmstate: port mips cpu, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 23/35] vmstate: port arm cpu, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 30/35] vmstate: Add copyright info for cris processor, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 25/35] vmstate: fix vmstate formating for i386, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 34/35] vmstate: Add copyright info for ppc processor, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 32/35] vmstate: Add copyright info for i386 processor, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 28/35] vmstate: Add copyright info for alpha processor, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 31/35] vmstate: Add copyright info for arm processor, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 33/35] vmstate: Add copyright info for mips processor, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 27/35] vmstate: rename machine.c to vmstate-cpu.c, Juan Quintela, 2012/05/04
- Re: [Qemu-devel] [PATCH v5 00/35] VMState port of all cpus, Andreas Färber, 2012/05/04