[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] runstate: introduce suspended state
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] runstate: introduce suspended state |
Date: |
Sat, 05 May 2012 09:55:35 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120425 Thunderbird/12.0 |
Il 04/05/2012 19:13, Luiz Capitulino ha scritto:
>>>> > >> This breaks QAPI ABI.
>>>> > >>
>>>> > >> Not really a breaker for this series, but it shows how we are not yet
>>>> > >> ready to keep a stable ABI (as opposed to API), and thus any
>>> > >
>>> > > Having to add a new enum every time a new value is needed is going to
>>> > > be fun.
>> >
>> > I think Paolo's point was that new values should be added at the end of
>> > the list. Your patch, as written, changes 'watchdog' from 13th to 14th;
>> > what you should have done is left 'watchdog' at 13th and made
>> > 'suspended' be 14th.
>
> We don't have a stable QAPI ABI today, and if I'm not missing the point
> here he's advocating against it.
Yes, but Eric's solution would be fine.
> I don't think this series need any changes in that regard.
I agree.
Paolo
[Qemu-devel] [PATCH 2/4] qapi-schema.json: fix RunState enums alphabetical order, Luiz Capitulino, 2012/05/04