[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/6] qemu-ga: guest-suspend-disk: don't emit a succe
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PATCH 4/6] qemu-ga: guest-suspend-disk: don't emit a success response |
Date: |
Tue, 8 May 2012 14:24:47 -0300 |
Today, qemu-ga may not be able to emit a success response when
guest-suspend-disk completes. This happens because the VM may
vanish before qemu-ga is able to emit a response.
This semantic is a bit confusing, as it's not clear for clients if
they should wait for a response or how they should check for success.
This commit solves that problem by changing guest-suspend-disk to
never emit a success response and suggests in the documentation
what clients could do to check for success.
Signed-off-by: Luiz Capitulino <address@hidden>
---
qapi-schema-guest.json | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/qapi-schema-guest.json b/qapi-schema-guest.json
index 82f901a..64db215 100644
--- a/qapi-schema-guest.json
+++ b/qapi-schema-guest.json
@@ -363,17 +363,21 @@
# For the best results it's strongly recommended to have the pm-utils
# package installed in the guest.
#
-# Returns: nothing on success
+# This command does NOT return a response on success. There is a high chance
+# the command succeeded if the VM exits with a zero exit status or, when
+# running with --no-shutdown, by issuing the query-status QMP command to
+# to confirm the VM status is "shutdown". However, the VM could also exit
+# (or set its status to "shutdown") due to other reasons.
+#
+# The following errors may be returned:
# If suspend to disk is not supported, Unsupported
#
-# Notes: o This is an asynchronous request. There's no guarantee a response
-# will be sent
-# o It's strongly recommended to issue the guest-sync command before
-# sending commands when the guest resumes
+# Notes: It's strongly recommended to issue the guest-sync command before
+# sending commands when the guest resumes
#
# Since: 1.1
##
-{ 'command': 'guest-suspend-disk' }
+{ 'command': 'guest-suspend-disk', 'success-response': 'no' }
##
# @guest-suspend-ram
--
1.7.9.2.384.g4a92a
- [Qemu-devel] [PATCH v2 0/6]: qemu-ga: no success response for certain commands, Luiz Capitulino, 2012/05/08
- [Qemu-devel] [PATCH 3/6] qemu-ga: guest-shutdown: don't emit a success response, Luiz Capitulino, 2012/05/08
- [Qemu-devel] [PATCH 6/6] qemu-ga: guest-suspend-hybrid: don't emit a success response, Luiz Capitulino, 2012/05/08
- [Qemu-devel] [PATCH 1/6] qapi: add support for command options, Luiz Capitulino, 2012/05/08
- [Qemu-devel] [PATCH 5/6] qemu-ga: guest-suspend-ram: don't emit a success response, Luiz Capitulino, 2012/05/08
- [Qemu-devel] [PATCH 2/6] qemu-ga: don't warn on no command return, Luiz Capitulino, 2012/05/08
- [Qemu-devel] [PATCH 4/6] qemu-ga: guest-suspend-disk: don't emit a success response,
Luiz Capitulino <=
- Re: [Qemu-devel] [PATCH v2 0/6]: qemu-ga: no success response for certain commands, Michael Roth, 2012/05/09