[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1.1 11/22] qemu-io: correctly print non-integer

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 1.1 11/22] qemu-io: correctly print non-integer values as decimals
Date: Wed, 09 May 2012 14:48:20 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120425 Thunderbird/12.0

Il 09/05/2012 14:46, Kevin Wolf ha scritto:
>> > The changes to all other files were scripted with sed, so there were
>> > no "surprises" beyond 027.out and 033.out.
>> > 
>> > Signed-off-by: Paolo Bonzini <address@hidden>
>> > ---
>> >         035.out has an extra long line which stumps git send-email,
>> >         so I forced generation of a binary diff.  Always learning
>> >         new things.
> How do you do that, and even for single files in a larger commit?

I added this temporarily to my ".git/info/attributes":

tests/qemu-iotests/035.out -diff

> When I patched 035.out in the past, I used git send-email --no-validate,
> but binary patches are probably better.

Depends on what the change is.  It does add a step for the reviewer to
look at the diff.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]