Re: [Qemu-devel] [PATCH 13/22] virtio-9p: avoid unwarranted use of strncpy

[Aneesh Kumar K.V]

Jim Meyering <address@hidden> writes:

> From: Jim Meyering <address@hidden>
>
> The use of strncpy in pt_listxattr is unnecessary, since we
> know that the NUL-terminated source bytes fit in the destination
> buffer.  Use memcpy in place of strncpy.
>
> Signed-off-by: Jim Meyering <address@hidden>

Fold this with Patch 11 ?

Reviewed-by: Aneesh Kumar K.V <address@hidden>


> ---
>  hw/9pfs/virtio-9p-xattr.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/9pfs/virtio-9p-xattr.c b/hw/9pfs/virtio-9p-xattr.c
> index 7f08f6e..a839606 100644
> --- a/hw/9pfs/virtio-9p-xattr.c
> +++ b/hw/9pfs/virtio-9p-xattr.c
> @@ -53,7 +53,8 @@ ssize_t pt_listxattr(FsContext *ctx, const char *path,
>          return -1;
>      }
>
> -    strncpy(value, name, name_size);
> +    /* no need for strncpy: name_size is strlen(name)+1 */
> +    memcpy(value, name, name_size);
>      return name_size;
>  }
>
> -- 
> 1.7.10.1.487.ga3935e6