[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] coroutine-ucontext broken for x86-32

From: Avi Kivity
Subject: Re: [Qemu-devel] coroutine-ucontext broken for x86-32
Date: Wed, 09 May 2012 17:37:40 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1

On 05/09/2012 02:15 PM, Peter Maydell wrote:
> I think it's becoming increasingly obvious that the setcontext/getcontext
> code path is not very well used and prone to nasty libc bugs. Trying
> to implement coroutines in C is just a really bad idea and I think
> we should be trying to reduce our use of them if we possibly can,
> presumably by switching to actually using threads where we really
> need the parallelism.

I happen to like coroutines, but if we switch to threads, we should
ensure that we eliminate the extra context switch if the layer below
(usually posix-aio-compat) also uses threads.  That leaves a theoretical
regression with qcow2-on-native-aio, but that's a fairly rare use case.

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]