[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH next v2 00/74] QOM CPUState, part 3: CPU reset
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH next v2 00/74] QOM CPUState, part 3: CPU reset |
Date: |
Thu, 10 May 2012 22:26:52 +0100 |
On 10 May 2012 22:05, Andreas Färber <address@hidden> wrote:
> Am 10.05.2012 22:35, schrieb Peter Maydell:
>> Something this
>> big is just too painful to work with.
>
> I don't see your point. Our mailboxes have thousands of messages either
> way, you've only been cc'ed on those you are in MAINTAINERS for, and
> applying 5 patches from a 74-patch series is not more work than applying
> 5 patches from a 5-patch series, is it?
It is, because it requires work from me to be sure that I have all
the intended patches and none of the unintended ones. A five patch
series is a small and clearly bounded set of work; a 74 patch series
is a much bigger job, because the assumption is that there are
interdependencies within it such that it doesn't make sense to
review only a small part of it, otherwise the submitter would have
split it up in the first place.
(My mail client makes no distinction between qemu-devel messages I
get cc'd on and ones I don't, incidentally.)
> This series is put together in such a way that it achieves a goal:
> removing cpu_state_reset(). I can send you these and more patches
> refactoring ARM devices but then it'll be perceived as "just churn".
> 74 sounds like much, but the patches are pretty easy to review, no?
> These 74 are a subset of a currently 138-patch series and growing -
> that's why agreeing on a merge order for qom-next is so important to me.
>
> If I send these out in series of 5 patches and wait for each to get
> merged through different trees then by the current rate of applying
> this'll take years, especially if we're blocked by unmaintained targets...
If you just want a reviewed-by from me and to put the whole series in
to the tree via some other route that's also fine by me.
-- PMM
- [Qemu-devel] [PATCH next v2 00/74] QOM CPUState, part 3: CPU reset, Andreas Färber, 2012/05/09
- [Qemu-devel] [PATCH next v2 04/74] target-i386: Let cpu_x86_init() return X86CPU, Andreas Färber, 2012/05/09
- [Qemu-devel] [PATCH next v2 03/74] target-i386: Pass X86CPU to do_cpu_{init, sipi}(), Andreas Färber, 2012/05/09
- [Qemu-devel] [PATCH next v2 01/74] target-arm: Use cpu_reset() in cpu_arm_init(), Andreas Färber, 2012/05/09
- [Qemu-devel] [PATCH next v2 02/74] target-mips: Use cpu_reset() in cpu_mips_init(), Andreas Färber, 2012/05/09
- Re: [Qemu-devel] [PATCH next v2 00/74] QOM CPUState, part 3: CPU reset, Andreas Färber, 2012/05/10
- Re: [Qemu-devel] [PATCH next v2 00/74] QOM CPUState, part 3: CPU reset, Peter Maydell, 2012/05/10
- Re: [Qemu-devel] [PATCH next v2 00/74] QOM CPUState, part 3: CPU reset, Max Filippov, 2012/05/14
- Re: [Qemu-devel] [PATCH next v2 00/74] QOM CPUState, part 3: CPU reset, Alexander Graf, 2012/05/21